linux-kernel - Re: [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJVLZfvh0p0qpcS+V3Cwuv-mi6o-hO5X-JThj-T_0dOCVw@mail.gmail.com>
Date:   Wed, 11 Dec 2019 10:47:11 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Vignesh Raghavendra <vigneshr@...com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type

pon., 9 gru 2019 o 07:27 Vignesh Raghavendra <vigneshr@...com> napisał(a):
>
> Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
> handler. IRQ/platform core will take care of setting appropriate trigger
> type.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> ---
> v2:
> Drop explicit call to irq_get_trigger_type() as this is take care of in core
> code.
>
>  drivers/gpio/gpio-pca953x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..40e48f7d83bb 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
>
>         ret = devm_request_threaded_irq(&client->dev, client->irq,
>                                         NULL, pca953x_irq_handler,
> -                                       IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> -                                       IRQF_SHARED,
> +                                       IRQF_ONESHOT | IRQF_SHARED,
>                                         dev_name(&client->dev), chip);
>         if (ret) {
>                 dev_err(&client->dev, "failed to request irq %d\n",
> --
> 2.24.0
>

Patch applied, thanks!

Bartosz