linux-kernel - RE: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <744357E9AAD1214791ACBA4B0B90926377677DF1@SHSMSX108.ccr.corp.intel.com>
Date:   Wed, 11 Dec 2019 10:33:07 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: RE: [PATCH] cpuidle: Drop unnecessary type cast in
 cpuidle_poll_time()


> -----Original Message-----
> From: linux-pm-owner@...r.kernel.org [mailto:linux-pm-
> owner@...r.kernel.org] On Behalf Of Rafael J. Wysocki
> Sent: Wednesday, December 11, 2019 6:31 PM
> To: Linux PM <linux-pm@...r.kernel.org>
> Cc: LKML <linux-kernel@...r.kernel.org>; Daniel Lezcano
> <daniel.lezcano@...aro.org>
> Subject: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll_time()
> 
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The data type of the target_residency_ns field in struct cpuidle_state is u64,
> so it does not need to be cast into u64.
> 
> Get read of the unnecessary type cast.

s/read/rid

thanks,
rui
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> 
> On top of the linux-next branch of linux-pm.git from today.
> 
> ---
>  drivers/cpuidle/cpuidle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/cpuidle/cpuidle.c
> ==============================================================
> =====
> --- linux-pm.orig/drivers/cpuidle/cpuidle.c
> +++ linux-pm/drivers/cpuidle/cpuidle.c
> @@ -381,7 +381,7 @@ u64 cpuidle_poll_time(struct cpuidle_dri
>  		if (dev->states_usage[i].disable)
>  			continue;
> 
> -		limit_ns = (u64)drv->states[i].target_residency_ns;
> +		limit_ns = drv->states[i].target_residency_ns;
>  		break;
>  	}
> 
> 
>