linux-kernel - Re: [PATCH 4/7] Input: gtco: fix endpoint sanity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Dec 2019 06:59:06 -0500 (EST)
From:   Vladis Dronov <vdronov@...hat.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH 4/7] Input: gtco: fix endpoint sanity check

Thanks, Johan! A fix for a bug indeed.

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer

----- Original Message -----
> From: "Johan Hovold" <johan@...nel.org>
> To: "Dmitry Torokhov" <dmitry.torokhov@...il.com>
> Cc: linux-input@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, "Johan Hovold"
> <johan@...nel.org>, "stable" <stable@...r.kernel.org>, "Vladis Dronov" <vdronov@...hat.com>
> Sent: Tuesday, December 10, 2019 12:37:34 PM
> Subject: [PATCH 4/7] Input: gtco: fix endpoint sanity check
> 
> The driver was checking the number of endpoints of the first alternate
> setting instead of the current one, something which could lead to the
> driver binding to an invalid interface.
> 
> This in turn could cause the driver to misbehave or trigger a WARN() in
> usb_submit_urb() that kernels with panic_on_warn set would choke on.
> 
> Fixes: 162f98dea487 ("Input: gtco - fix crash on detecting device without
> endpoints")
> Cc: stable <stable@...r.kernel.org>     # 4.6
> Cc: Vladis Dronov <vdronov@...hat.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>