linux-kernel - RE: perf top for arm64?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4618A2196EA1E57D979B1C3AE65A0@DB7PR04MB4618.eurprd04.prod.outlook.com>
Date:   Wed, 11 Dec 2019 01:48:30 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Jiri Olsa <jolsa@...hat.com>, John Garry <john.garry@...wei.com>
CC:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "will@...nel.org" <will@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linuxarm <linuxarm@...wei.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>
Subject: RE: perf top for arm64?


> -----Original Message-----
> From: linux-perf-users-owner@...r.kernel.org
> <linux-perf-users-owner@...r.kernel.org> On Behalf Of Jiri Olsa
> Sent: 2019年12月11日 1:09
> To: John Garry <john.garry@...wei.com>
> Cc: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>;
> peterz@...radead.org; mingo@...hat.com;
> alexander.shishkin@...ux.intel.com; namhyung@...nel.org;
> mark.rutland@....com; will@...nel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; Linuxarm <linuxarm@...wei.com>;
> linux-perf-users@...r.kernel.org
> Subject: Re: perf top for arm64?
> 
> On Tue, Dec 10, 2019 at 04:52:52PM +0000, John Garry wrote:
> > On 10/12/2019 16:36, Jiri Olsa wrote:
> > > On Tue, Dec 10, 2019 at 04:13:49PM +0000, John Garry wrote:
> > > > Hi all,
> > > >
> > > > I find to my surprise that "perf top" does not work for arm64:
> > > >
> > > > root@...ntu:/home/john/linux# tools/perf/perf top Couldn't read
> > > > the cpuid for this machine: No such file or directory
> > >
> >
> > Hi Jirka,
> >
> > > there was recent change that check on cpuid and quits:
> > >    608127f73779 perf top: Initialize perf_env->cpuid, needed by the
> > > per arch annotation init routine
> > >
> >
> > ok, this is new code. I obviously didn't check the git history...
> >
> > But, apart from this, there are many other places where get_cpuid() is
> > called. I wonder what else we're missing out on, and whether we should
> > still add it.
> 
> right, I was just wondering how come vendor events are working for you, but
> realized we have get_cpuid_str being called in there ;-)
> 
> I think we should add it as you have it prepared already, could you post it with
> bigger changelog that would explain where it's being used for arm?

Hi Jirka,

I reported metricgroup cannot work on ARM64 before, however, no one can come up with a solution, could you take a look how to fix it? Thanks a lot!

You can refer to below link for more info:
	[1] https://www.spinics.net/lists/linux-perf-users/msg09190.html (NACK by Will Deason)
	[2] https://www.spinics.net/lists/linux-perf-users/msg09324.html

Best Regards,
Joakim Zhang
> jirka