linux-kernel - Re: [PATCH 2/2] net: ethernet: ti: build cpsw-common for switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6d7c4ec-dd85-e979-bc9f-49f5b0637447@ti.com>
Date:   Wed, 11 Dec 2019 15:19:59 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>
CC:     Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Murali Karicheri <m-karicheri2@...com>,
        Andrew Lunn <andrew@...n.ch>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] net: ethernet: ti: build cpsw-common for switchdev



On 11/12/2019 14:56, Arnd Bergmann wrote:
> Without the common part of the driver, the new file fails to link:
> 
> drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_probe':
> cpsw_new.c:(.text+0x312c): undefined reference to `ti_cm_get_macid'
> 
> Use the same Makefile hack as before, and build cpsw-common.o for
> any driver that needs it.
> 
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/ti/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile
> index d34df8e5cf94..ecf776ad8689 100644
> --- a/drivers/net/ethernet/ti/Makefile
> +++ b/drivers/net/ethernet/ti/Makefile
> @@ -5,6 +5,7 @@
>   
>   obj-$(CONFIG_TI_CPSW) += cpsw-common.o
>   obj-$(CONFIG_TI_DAVINCI_EMAC) += cpsw-common.o
> +obj-$(CONFIG_TI_CPSW_SWITCHDEV) += cpsw-common.o
>   
>   obj-$(CONFIG_TLAN) += tlan.o
>   obj-$(CONFIG_CPMAC) += cpmac.o
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>

-- 
Best regards,
grygorii