linux-kernel - Re: [PATCH] ELF: don't copy ELF header around

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191210175611.d615f21e177d5a550a8926f0@linux-foundation.org>
Date:   Tue, 10 Dec 2019 17:56:11 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ELF: don't copy ELF header around

On Sun, 8 Dec 2019 20:12:42 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:

> ELF header is read into bprm->buf[] by generic execve code.
> 
> Save a memcpy and allocate just one header for the interpreter instead
> of two headers (64 bytes instead of 128 on 64-bit).

Hard to review.  Why were there two copies in the first place?  Because
of the need to modify the caller's version when we do
`loc->elf_ex.e_entry += load_bias', yes?  Any other place?

Local variable `loc' can go away now, yes?