linux-kernel - Re: Patch "mm, vmstat: make quiet_vmstat lighter" has been added to the 4.4-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211144614.GA637714@kroah.com>
Date:   Wed, 11 Dec 2019 15:46:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "zhangyi (F)" <yi.zhang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        cl@...ux.com, mgalbraith@...e.de, mhocko@...e.com,
        torvalds@...ux-foundation.org, umgwanakikbuti@...il.com,
        wagi@...om.org, stable-commits@...r.kernel.org,
        "Wangkefeng (Maro)" <wangkefeng.wang@...wei.com>,
        Xie XiuQi <xiexiuqi@...wei.com>
Subject: Re: Patch "mm, vmstat: make quiet_vmstat lighter" has been added to
 the 4.4-stable tree

On Wed, Dec 11, 2019 at 10:32:49PM +0800, zhangyi (F) wrote:
> Hi, all
> 
> We find a performance degradation under lmbench af_unix[1] test case after
> mergeing this patch on my x86 qemu 4.4 machine. The test result is basically
> stable for each teses.
> 
> Host machine: CPU: Intel(R) Xeon(R) CPU E5-2690 v3
>               CPU(s): 48
>               MEM: 193047 MB
> 
> Guest machine:  CPU: QEMU Virtual CPU version 2.5+
>                 CPU(s): 8
>                 MEM: 26065 MB
> 
>   Before this patch:
>   [root@...alhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 133.7073 microseconds
> 
>   After this patch:
>   [root@...alhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 156.4722 microseconds
> 
> If we set task to a constant cpu, the degradation does not appear.
> 
>   Before this patch:
>   [root@...alhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 17.9296 microseconds
> 
>   After this patch:
>   [root@...alhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 17.7500 microseconds
> 
> We also test it on the aarch64 hi1215 machine with 8 cpu cores.
> 
>   Before this patch:
>   [root@...alhost ~]# ./lat_unix -P 1
>   AF_UNIX sock stream latency: 30.7 microseconds
> 
>   After this patch:
>   [root@...alhost ~]# ./lat_unix -P 1
>   AF_UNIX sock stream latency: 37.5 microseconds
> 
> Accessories included my reproduce config for x86 qemu. Any thoughts?

This fixes a bug, as reported by Daniel Wagner.  So it's probably better
to have a stable system instead of a broken one, right?  :)

Daniel can provide more information if needed.

What about when you run your tests on a 4.9 or newer kernel that already
has this integrated?

thanks,

greg k-h