linux-kernel - Re: [PATCH] igb: index regs_buff array via index variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 10:49:56 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gomonovych@...il.com
Cc:     jeffrey.t.kirsher@...el.com, intel-wired-lan@...ts.osuosl.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] igb: index regs_buff array via index variable

From: Vasyl Gomonovych <gomonovych@...il.com>
Date: Thu, 12 Dec 2019 11:58:47 +0100

> This patch is just a preparation for additional register dump in regs_buff.
> To make new register insertion in the middle of regs_buff array easier
> change array indexing to use local counter reg_ix.
> 
> ---
> 
> Basically this path is just a subject to ask
> How to add a new register to dump from dataseet
> Because it is logically better to add an additional register
> in the middle of an array but that will break ABI.
> To not have the ABI problem we should just add it at the
> end of the array and increase the array size.
> 
> ---
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

Anything you put after "---" will be removed by git if someone actually
applies this patch, which means your signoff will disappear.