linux-kernel - Re: [PATCH] net: l2tp: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 11:03:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     info@...ux.net
Cc:     linux-kernel@...r.kernel.org, jchapman@...alix.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage

From: "Enrico Weigelt, metux IT consult" <info@...ux.net>
Date: Thu, 12 Dec 2019 14:36:13 +0100

> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>

Is there a plan to remove MODULE_VERSION across the entire kernel tree?

Where is that documented?

Otherwise what gave you the reason to make this change in the first place?

No context, no high level explanation of what's going on, so it's hard
to review and decide whether to accept your change sorry.

At the least, you will have to write a more complete commit log message.