linux-kernel - CONFIG_COMMON_CLK vs CONFIG_HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   12 Dec 2019 11:09:22 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: CONFIG_COMMON_CLK vs CONFIG_HAVE_CLK


Hi

I noticed that there are some CONFIG_HAVE_CLK vs CONFIG_COMMON_CLK mismatch.
Because of it, I got compile error at clk_set_min_rate() on SH.
SH will have HAVE_CLK, but doesn't have COMMON_CLK.

	> ARCH=sh make allyesconfig
	> make
	...
	drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
	tegra30-devfreq.c:(.text+0x368): undefined reference to `clk_set_min_rate'

clk_set_min_rate() is under HAVE_CLK at clk.h

	--- clk.h ---
=>	#ifdef CONFIG_HAVE_CLK
	...
	int clk_set_min_rate(struct clk *clk, unsigned long rate);
	...
	#else /* !CONFIG_HAVE_CLK */
	static inline int clk_set_min_rate(struct clk *clk, unsigned long rate)
	...
	-------------

It is implemented at clk.c.
But it will be compiled via COMMON_CLK

	--- Makefile ---
	...
=>	obj-$(CONFIG_COMMON_CLK)	+= clk.o
	...
	----------------

Thank you for your help !!
Best regards
---
Kuninori Morimoto