linux-kernel - Re: [PATCH] USB: musb: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 14:43:26 -0600
From:   Bin Liu <b-liu@...com>
To:     "Ben Dooks (Codethink)" <ben.dooks@...ethink.co.uk>
CC:     <linux-kernel@...ts.codethink.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: musb: fix __iomem in trace functions

Hi,

On Tue, Oct 15, 2019 at 04:03:09PM +0100, Ben Dooks (Codethink) wrote:
> The trace functions should have __iomem on the addr
> pointers. Add __iomem to avoid the following warnings
> from sparse:
> 
> drivers/usb/musb/musb_core.c:253:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:253:55:    expected void const *addr
> drivers/usb/musb/musb_core.c:253:55:    got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:259:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:259:56:    expected void const *addr
> drivers/usb/musb/musb_core.c:259:56:    got void [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:267:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:267:55:    expected void const *addr
> drivers/usb/musb/musb_core.c:267:55:    got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:273:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:273:56:    expected void const *addr
> drivers/usb/musb/musb_core.c:273:56:    got void [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:383:55: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:383:55:    expected void const *addr
> drivers/usb/musb/musb_core.c:383:55:    got void const [noderef] <asn:2> *addr
> drivers/usb/musb/musb_core.c:390:56: warning: incorrect type in argument 2 (different address spaces)
> drivers/usb/musb/musb_core.c:390:56:    expected void const *addr
> drivers/usb/musb/musb_core.c:390:56:    got void [noderef] <asn:2> *addr
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Thanks for the patch. But checkpatch.pl complains that the author and
Signed-off-by do not match. Can you please fix it and re-send?

-Bin.