linux-kernel - Re: [PATCH v5 0/6] Fix nits in the kunit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 03:12:19 +0100
From:   SeongJae Park <sj38.park@...il.com>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     shuah <shuah@...nel.org>, SeongJae Park <sjpark@...zon.com>,
        Jonathan Corbet <corbet@....net>,
        KUnit Development <kunit-dev@...glegroups.com>,
        linux-doc <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, SeongJae Park <sjpark@...zon.de>
Subject: Re: [PATCH v5 0/6] Fix nits in the kunit

On Thu, Dec 12, 2019 at 3:06 AM Brendan Higgins
<brendanhiggins@...gle.com> wrote:
>
> On Wed, Dec 11, 2019 at 9:45 AM Brendan Higgins
> <brendanhiggins@...gle.com> wrote:
> >
> > On Wed, Dec 11, 2019 at 9:40 AM SeongJae Park <sj38.park@...il.com> wrote:
> > >
> > > On Wed, Dec 11, 2019 at 6:22 PM shuah <shuah@...nel.org> wrote:
> > > >
> > > > On 12/11/19 9:33 AM, SeongJae Park wrote:
> > > > > May I ask some comments?
>
> SeongJae,
>
> I reviewed and tested all your patches. Everything looks good to me
> with one minor caveat: I tried applying your patches on
> kselftest/fixes[1] and got the following error:
>
> error: patch failed: Documentation/dev-tools/kunit/start.rst:21
> error: Documentation/dev-tools/kunit/start.rst: patch does not apply
> Patch failed at 0005 kunit: Rename 'kunitconfig' to '.kunitconfig'
>
> I think the merge conflict is fairly straightforward, but it would
> still probably make Shuah's life easier if you rebased your patches.

Appreciate your nice response, I will rebase it and send the next version!


Thanks,
SeongJae Park

>
> Cheers!
>
> P.S. Thanks for the patch adding the test case for test the build_dir
> thing. I really appreciate that!
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes