linux-kernel - Re: READ_ONCE() + STACKPROTECTOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 22:09:49 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/

On Fri, Dec 13, 2019 at 12:00:52AM +0300, Alexey Dobriyan wrote:
> > We could move the kernel to C++ and write:
> > 
> > 	std::remove_volatile<typeof(p)>::type __p = (p);
> > 
> > /me runs like hell...
> 
> Did you just said I can send "struct sched_domain::private" and
> "struct wait_queue_entry::private" rename?
> :^)

I don't believe those are the only usage of C++ keywords. IIRC I'm using
'class' somewhere as well.

> Doable but not until C++20. constinit and designated initializers are
> pretty mandatory.
> 
> Debian GNU/Linux 8 debian88 ttyS0
> 
> debian88 login: root
> Password:
> Last login: Thu Sep 19 01:04:29 +03 2019 on tty1
> Linux debian88 5.3.0+ #1 SMP PREEMPT Thu Sep 19 01:02:26 +03 2019 x86_64
> root@...ian88:~# cat /proc/$(pgrep sshd)/stack
> [<0>] _ZL9do_selectiP11fd_set_bitsP10timespec64+0x5ac/0x750
> [<0>] _Z15core_sys_selectiP15__kernel_fd_setS0_S0_P10timespec64+0x143/0x260

Argh.. I forgot how I hated mangled names.

> [<0>] __x64_sys_select+0xa7/0xf0
> [<0>] do_syscall_64+0x3b/0xe7
> [<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9