linux-kernel - Re: [PATCH 6/7] arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 13:59:52 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Douglas Anderson <dianders@...omium.org>
Cc:     Vinod Koul <vkoul@...nel.org>, Kiran Gunda <kgunda@...eaurora.org>,
        Rajendra Nayak <rnayak@...eaurora.org>, mka@...omium.org,
        Sandeep Maheswaram <sanm@...eaurora.org>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        Maulik Shah <mkshah@...eaurora.org>,
        Douglas Anderson <dianders@...omium.org>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 6/7] arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper

Quoting Douglas Anderson (2019-12-12 11:35:42)
> The bindings for the QMP PHY are truly strange.  I believe (?) that
> they may have originated because with PCIe each lane is treated as a
> different PHY and the same PHY driver is used for a whole bunch of
> things (incluidng PCIe).
> 
> In any case, now that we have "make dtbs_check", we find that having
> the outer node named "phy" triggers the
> "schemas/phy/phy-provider.yaml" schema, yelling about:
> 
>   phy@...9000: '#phy-cells' is a required property
> 
> Let's call the outer node the "phy-wrapper" and the inner node the
> "phy" to make dtbs_check happy.
> 
> Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

Would be good to add phy-wrapper to possible node names in the DT spec
too.