linux-kernel - Re: [v4 2/2] arm64: dts: ls1028a: Update edma compatible to fit eDMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 10:19:51 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Peng Ma <peng.ma@....com>
Cc:     "vkoul@...nel.org" <vkoul@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Leo Li <leoyang.li@....com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        Robin Gong <yibin.gong@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [v4 2/2] arm64: dts: ls1028a: Update edma compatible to fit eDMA
 driver

On Wed, Dec 11, 2019 at 08:09:39AM +0000, Peng Ma wrote:
> The eDMA of LS1028A soc has a little bit different from others, So we
> should distinguish them in driver by compatible.
> 
> Signed-off-by: Peng Ma <peng.ma@....com>
> ---
> Changed for v4
> 	- Add new change patch
> 
>  Documentation/devicetree/bindings/dma/fsl-edma.txt | 1 +

Please have bindings change as a separate patch.

Shawn

>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi     | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl-edma.txt b/Documentation/devicetree/bindings/dma/fsl-edma.txt
> index 29dd3ccb1235..e77b08ebcd06 100644
> --- a/Documentation/devicetree/bindings/dma/fsl-edma.txt
> +++ b/Documentation/devicetree/bindings/dma/fsl-edma.txt
> @@ -10,6 +10,7 @@ Required properties:
>  - compatible :
>  	- "fsl,vf610-edma" for eDMA used similar to that on Vybrid vf610 SoC
>  	- "fsl,imx7ulp-edma" for eDMA2 used similar to that on i.mx7ulp
> +	- "fsl,fsl,ls1028a-edma" for eDMA used similar to that on Vybrid vf610 SoC
>  - reg : Specifies base physical address(s) and size of the eDMA registers.
>  	The 1st region is eDMA control register's address and size.
>  	The 2nd and the 3rd regions are programmable channel multiplexing
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8e8a77eb596a..b3716a89fa0d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -316,7 +316,7 @@
>  
>  		edma0: dma-controller@...0000 {
>  			#dma-cells = <2>;
> -			compatible = "fsl,vf610-edma";
> +			compatible = "fsl,ls1028a-edma";
>  			reg = <0x0 0x22c0000 0x0 0x10000>,
>  			      <0x0 0x22d0000 0x0 0x10000>,
>  			      <0x0 0x22e0000 0x0 0x10000>;
> -- 
> 2.17.1
>