[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 01:21:57 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Barret Rhoden <brho@...gle.com>,
Dan Williams <dan.j.williams@...el.com>,
David Hildenbrand <david@...hat.com>,
Dave Jiang <dave.jiang@...el.com>,
Alexander Duyck <alexander.h.duyck@...ux.intel.com>
Cc: linux-nvdimm@...ts.01.org, x86@...nel.org, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, jason.zeng@...el.com
Subject: Re: [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files
On 11/12/19 22:32, Barret Rhoden wrote:
> + /*
> + * Our caller grabbed the KVM mmu_lock with a successful
> + * mmu_notifier_retry, so we're safe to walk the page table.
> + */
> + switch (dev_pagemap_mapping_shift(hva, current->mm)) {
> + case PMD_SHIFT:
> + case PUD_SIZE:
> + return true;
> + }
> + return false;
Should this simply be "> PAGE_SHIFT"?
Paolo
Powered by blists - more mailing lists