[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Dec 2019 19:41:16 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Guenter Roeck <linux@...ck-us.net>,
Denis Efremov <efremov@...ux.com>,
linux-watchdog@...r.kernel.org
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
open list <linux-kernel@...r.kernel.org>,
linux-mips@...ux-mips.org, Paul Burton <paulburton@...nel.org>
Subject: Re: [PATCH 0/2] watchdog: mtx-1: Relax build dependencies
On 12/11/2019 5:39 PM, Guenter Roeck wrote:
> On 12/11/19 3:46 PM, Denis Efremov wrote:
>> Hi,
>>
>> Thanks for the fix.
>> I tested the compilation with these patches.
>> You can add my:
>> Tested-by: Denis Efremov <efremov@...ux.com>
>>
>> Look like this error could be fixed the same way:
>> In file included from drivers/watchdog/ar7_wdt.c:29:
>> ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’:
>> ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit
>> declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’?
>> [-Werror=implicit-function-declaration]
>>
>
> This is yet another old-style watchdog driver which should be left alone
> unless it has a bug that needs to be fixed. Really, if anyone out there
> is still using this driver, converting it to use the watchdog core
> would make much more sense.
AR7 is still largely available, so we might be able to get some people
within the OpenWrt community to give a watchdog modernization patch a try.
--
Florian
Powered by blists - more mailing lists