lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Dec 2019 16:30:03 -0800 From: Brendan Higgins <brendanhiggins@...gle.com> To: Joel Stanley <joel@....id.au> Cc: Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, Andrew Jeffery <andrew@...id.au>, Jeremy Kerr <jk@...abs.org>, Alistar Popple <alistair@...ple.id.au>, Eddie James <eajames@...ux.ibm.com>, linux-um <linux-um@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, David Gow <davidgow@...gle.com>, linux-fsi@...ts.ozlabs.org, Linux ARM <linux-arm-kernel@...ts.infradead.org>, linux-aspeed <linux-aspeed@...ts.ozlabs.org> Subject: Re: [PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel@....id.au> wrote: > > On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins@...gle.com> wrote: > > > > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe': > > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the unspecified dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@...gle.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com> > > Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in > order to build some ARM drivers under UM. Do you have plans to fix > that too? The only broken configs I found for UML are all listed on the cover letter of this patch. I think fixing COMPILE_TEST on UM could be worthwhile. Did you see any brokenness other than what I mentioned on the cover letter? > Do you want to get this in a fix for 5.5? Preferably, yes. > Acked-by: Joel Stanley <joel@....id.au> Thanks!
Powered by blists - more mailing lists