[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 11 Dec 2019 23:17:53 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Brian Masney <masneyb@...tation.org>
Cc: robdclark@...il.com, sean@...rly.run, robh+dt@...nel.org,
airlied@...ux.ie, daniel@...ll.ch, jcrouse@...eaurora.org,
dianders@...omium.org, linux-arm-msm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, mark.rutland@....com,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2 3/4] drm/msm/a3xx: set interconnect bandwidth vote
On Thu 21 Nov 17:26 PST 2019, Brian Masney wrote:
> Set the two interconnect paths for the GPU to maximum speed for now to
> work towards getting the GPU working upstream. We can revisit a later
> time to optimize this for battery life.
>
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
> index 07ddcc529573..eff0ecd4e81a 100644
> --- a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
> @@ -504,6 +504,14 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
> DRM_DEV_ERROR(dev->dev, "No memory protection without IOMMU\n");
> }
>
> + /*
> + * Set the ICC path to maximum speed for now by multiplying the fastest
> + * frequency by the bus width (8). We'll want to scale this later on to
> + * improve battery life.
I would expect that you have to worry about temperature before battery
life...
Regards,
Bjorn
> + */
> + icc_set_bw(gpu->icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);
> + icc_set_bw(gpu->ocmem_icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);
> +
> return gpu;
>
> fail:
> --
> 2.21.0
>
Powered by blists - more mailing lists