linux-kernel - Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI transfer delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 07:21:20 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "peterhuewe@....de" <peterhuewe@....de>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH V2] tpm_tis_spi: use new `delay` structure for SPI
 transfer delays

On Wed, 2019-12-11 at 19:37 +0200, Jarkko Sakkinen wrote:
> [External]
> 
> On Tue, Dec 10, 2019 at 08:56:19AM +0200, Alexandru Ardelean wrote:
> > In a recent change to the SPI subsystem [1], a new `delay` struct was
> > added
> > to replace the `delay_usecs`. This change replaces the current
> > `delay_usecs`
> > with `delay` for this driver.
> > 
> > The `spi_transfer_delay_exec()` function [in the SPI framework] makes
> > sure
> > that both `delay_usecs` & `delay` are used (in this order to preserve
> > backwards compatibility).
> > 
> > [1] commit bebcfd272df6485 ("spi: introduce `delay` field for
> > `spi_transfer` + spi_transfer_delay_exec()")
> 
> Not sure why you use ` and not '?

That's a habit from Github's Markdown.
We keep our kernel repo on Github and Markdown formats `text` into a
certain form.
When I open a PR, the PR text is formatted to highlight certain elements
[that I want highlighted].
I did not get any comments on it so far.

I can change it if you want.

As a secondary note: Markdown seems to be used on Gitlab and Bitbucket

Thanks
Alex

> 
> /Jarkko