[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 10:14:25 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Chuhong Yuan <hslester96@...il.com>
Cc: David Airlie <airlied@...ux.ie>, nouveau@...ts.freedesktop.org,
Chuhong Yuan <hslester96@...il.com>,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
Ben Skeggs <bskeggs@...hat.com>
Subject: Re: [PATCH] drm/dp_mst: add missed nv50_outp_release in nv50_msto_disable
On Fri, 06 Dec 2019, Chuhong Yuan <hslester96@...il.com> wrote:
> nv50_msto_disable() does not call nv50_outp_release() to match
> nv50_outp_acquire() like other disable().
> Add the missed call to fix it.
The subject prefix "drm/dp_mst" implies drm core change, but this is
about nouveau. Please fix.
BR,
Jani.
>
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index 549486f1d937..84e1417355cc 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -862,8 +862,10 @@ nv50_msto_disable(struct drm_encoder *encoder)
>
> mstm->outp->update(mstm->outp, msto->head->base.index, NULL, 0, 0);
> mstm->modified = true;
> - if (!--mstm->links)
> + if (!--mstm->links) {
> mstm->disabled = true;
> + nv50_outp_release(mstm->outp);
> + }
> msto->disabled = true;
> }
--
Jani Nikula, Intel Open Source Graphics Center
Powered by blists - more mailing lists