linux-kernel - RE: [PATCH] nios2: Fix ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 08:53:16 +0000
From:   "Tan, Ley Foon" <ley.foon.tan@...el.com>
To:     Guenter Roeck <linux@...ck-us.net>, Ley Foon Tan <lftan@...era.com>
CC:     "nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Christoph Hellwig" <hch@....de>
Subject: RE: [PATCH] nios2: Fix ioremap



> -----Original Message-----
> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Thursday, December 5, 2019 10:41 AM
> To: Ley Foon Tan <lftan@...era.com>
> Cc: nios2-dev@...ts.rocketboards.org; linux-kernel@...r.kernel.org;
> Guenter Roeck <linux@...ck-us.net>; Christoph Hellwig <hch@....de>
> Subject: [PATCH] nios2: Fix ioremap
> 
> Commit 5ace77e0b41a ("nios2: remove __ioremap") removed the following
> code, with the argument that cacheflag is always 0 and the expression would
> therefore always be false.
> 
>         if (IS_MAPPABLE_UNCACHEABLE(phys_addr) &&
>             IS_MAPPABLE_UNCACHEABLE(last_addr) &&
>             !(cacheflag & _PAGE_CACHED))
>                 return (void __iomem *)(CONFIG_NIOS2_IO_REGION_BASE +
> phys_addr);
> 
> This did not take the "!" in the expression into account. Result is that
> nios2 images no longer boot. Restoring the removed code fixes the problem.
> 
> Fixes: 5ace77e0b41a ("nios2: remove __ioremap")
> Cc: Christoph Hellwig <hch@....de>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Will add to next rc. 
Thanks.

Acked-by: Ley Foon Tan <ley.foon.tan@...el.com>