linux-kernel - Re: [PATCH] mmc: sdhci-s3c: remove unused ext_cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 10:57:28 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-mmc@...r.kernel.org
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Ben Dooks <ben-linux@...ff.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-s3c: remove unused ext_cd_gpio field

On 9/12/19 8:37 pm, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-s3c.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 51e096f27388..8b15945dd499 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -117,7 +117,6 @@ struct sdhci_s3c {
>  	struct s3c_sdhci_platdata *pdata;
>  	int			cur_clk;
>  	int			ext_cd_irq;
> -	int			ext_cd_gpio;
>  
>  	struct clk		*clk_io;
>  	struct clk		*clk_bus[MAX_BUS_CLK];
> @@ -512,7 +511,6 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
>  			goto err_pdata_io_clk;
>  	} else {
>  		memcpy(pdata, pdev->dev.platform_data, sizeof(*pdata));
> -		sc->ext_cd_gpio = -1; /* invalid gpio number */
>  	}
>  
>  	drv_data = sdhci_s3c_get_driver_data(pdev);
>