linux-kernel - Re: [PATCH -next] pinctrl: samsung: fix build error without CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 17:27:52 +0800
From:   Chen Zhou <chenzhou10@...wei.com>
To:     <tomasz.figa@...il.com>, <krzk@...nel.org>,
        <s.nawrocki@...sung.com>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] pinctrl: samsung: fix build error without
 CONFIG_OF_GPIO

ignore this patch, i will repost it.

On 2019/12/12 17:21, Chen Zhou wrote:
> If CONFIG_OF_GPIO is n, build fails:
> 
> drivers/pinctrl/samsung/pinctrl-samsung.c: In function samsung_gpiolib_register:
> drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: struct gpio_chip has no member named of_node
>    gc->of_node = bank->of_node;
> 
> Use #ifdef to guard this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>Fixes
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index f26574e..5c29ad8 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -966,7 +966,9 @@ static int samsung_gpiolib_register(struct platform_device *pdev,
>  		gc->base = bank->grange.base;
>  		gc->ngpio = bank->nr_pins;
>  		gc->parent = &pdev->dev;
> +#ifdef CONFIG_OF_GPIO
>  		gc->of_node = bank->of_node;
> +#endif
>  		gc->label = bank->name;
>  
>  		ret = devm_gpiochip_add_data(&pdev->dev, gc, bank);
>