linux-kernel - Re: [PATCH tip/core/rcu 01/12] rcu: Remove rcu_swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 09:31:50 +0000
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, mingo@...nel.org, jiangshanlai@...il.com,
        dipankar@...ibm.com, akpm@...ux-foundation.org,
        mathieu.desnoyers@...icios.com, josh@...htriplett.org,
        tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org,
        dhowells@...hat.com, edumazet@...gle.com, fweisbec@...il.com,
        oleg@...hat.com, joel@...lfernandes.org,
        Bart Van Assche <bart.vanassche@....com>,
        Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Shane M Seymour <shane.seymour@....com>,
        Felix Fietkau <nbd@....name>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Roy Luo <royluo@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH tip/core/rcu 01/12] rcu: Remove rcu_swap_protected()

+ linux-wireless

"Paul E. McKenney" <paulmck@...nel.org> writes:

> On Wed, Dec 11, 2019 at 08:09:11PM +0100, Matthias Brugger wrote:
>> On 11/12/2019 19:37, Paul E. McKenney wrote:
>>
>> > --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
>> > +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
>> > @@ -281,8 +281,8 @@ void mt76_rx_aggr_stop(struct mt76_dev *dev, struct mt76_wcid *wcid, u8 tidno)
>> >  {
>> >  	struct mt76_rx_tid *tid = NULL;
>> >  
>> > -	rcu_swap_protected(wcid->aggr[tidno], tid,
>> > -			   lockdep_is_held(&dev->mutex));
>> > +	tid = rcu_swap_protected(wcid->aggr[tidno], tid,
>> > +				 lockdep_is_held(&dev->mutex));
>> 
>> I suppose you meant: rcu_replace_pointer() here.
>
> Indeed I did, and thank you for catching this!  Bad patch day here.  :-/
>
> Update below...
>
> 							Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit ad5572b091429a45e863acaa6a36cf396d44f58d
> Author: Paul E. McKenney <paulmck@...nel.org>
> Date:   Wed Dec 11 10:30:21 2019 -0800
>
>     wireless/mediatek: Replace rcu_swap_protected() with rcu_replace_pointer()
>     
>     This commit replaces the use of rcu_swap_protected() with the more
>     intuitively appealing rcu_replace_pointer() as a step towards removing
>     rcu_swap_protected().
>     
>     Link: https://lore.kernel.org/lkml/CAHk-=wiAsJLw1egFEE=Z7-GGtM6wcvtyytXZA1+BHqta4gg6Hw@mail.gmail.com/
>     Reported-by: Linus Torvalds <torvalds@...ux-foundation.org>
>     Reported-by: "Martin K. Petersen" <martin.petersen@...cle.com>
>     [ paulmck: Apply Matthias Brugger feedback. ]
>     Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
>     Reviewed-by: "Martin K. Petersen" <martin.petersen@...cle.com>
>     Cc: Felix Fietkau <nbd@....name>
>     Cc: Lorenzo Bianconi <lorenzo.bianconi83@...il.com>
>     Cc: Ryder Lee <ryder.lee@...iatek.com>
>     Cc: Roy Luo <royluo@...gle.com>
>     Cc: Kalle Valo <kvalo@...eaurora.org>
>     Cc: "David S. Miller" <davem@...emloft.net>
>     Cc: Matthias Brugger <matthias.bgg@...il.com>
>     Cc: <linux-wireless@...r.kernel.org>
>     Cc: <netdev@...r.kernel.org>
>     Cc: <linux-arm-kernel@...ts.infradead.org>
>     Cc: <linux-mediatek@...ts.infradead.org>

Via which tree is this supposed to go? If I should take this please
resend to linux-wireless so that patchwork sees it, but if someone else
is planning to take this:

Acked-by: Kalle Valo <kvalo@...eaurora.org>

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches