| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b859b9f1-2d89-ddef-df26-724ac4ffb088@web.de>
Date: Thu, 12 Dec 2019 11:47:06 +0100
From: Soeren Moch <smoch@....de>
To: Robin Murphy <robin.murphy@....com>,
Kalle Valo <kvalo@...eaurora.org>,
Heiko Stuebner <heiko@...ech.de>
Cc: brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rockchip@...ts.infradead.org, brcm80211-dev-list@...ress.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth
at uart0
On 12.12.19 11:22, Robin Murphy wrote:
> Hi Soeren,
>
> On 11/12/2019 11:52 pm, Soeren Moch wrote:
>> With enabled wifi support (required for firmware loading) for the
>> Ampak AP6359SA based wifi/bt combo module we now also can enable
>> the bluetooth part.
>>
>> Suggested-by: Heiko Stuebner <heiko@...ech.de>
>> Signed-off-by: Soeren Moch <smoch@....de>
>> ---
>> changes in v2:
>> - new patch
>>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Kalle Valo <kvalo@...eaurora.org>
>> Cc: linux-wireless@...r.kernel.org
>> Cc: brcm80211-dev-list.pdl@...adcom.com
>> Cc: brcm80211-dev-list@...ress.com
>> Cc: netdev@...r.kernel.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-rockchip@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>> .../boot/dts/rockchip/rk3399-rockpro64.dts | 29 ++++++++++++++++++-
>> 1 file changed, 28 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> index 9fa92790d6e0..94cc462e234d 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
>> @@ -561,6 +561,20 @@
>> };
>>
>> &pinctrl {
>> + bt {
>> + bt_enable_h: bt-enable-h {
>> + rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
>> + };
>> +
>> + bt_host_wake_l: bt-host-wake-l {
>> + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_down>;
>> + };
>> +
>> + bt_wake_l: bt-wake-l {
>> + rockchip,pins = <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>;
>> + };
>> + };
>> +
>> buttons {
>> pwrbtn: pwrbtn {
>> rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO &pcfg_pull_up>;
>> @@ -729,8 +743,21 @@
>>
>> &uart0 {
>> pinctrl-names = "default";
>> - pinctrl-0 = <&uart0_xfer &uart0_cts>;
>> + pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>;
>> status = "okay";
>> +
>> + bluetooth {
>> + compatible = "brcm,bcm43438-bt";
>> + clocks = <&rk808 1>;
>> + clock-names = "extclk";
>
> Is this right? Comparing the binding and the naming on the schematics,
> it seems more likely that this might be the LPO clock rather than the
> TXCO clock.
>
> Robin.
On second thought I have to agree. So we need another round on this.
Thanks for your review and bug report,
Soeren
>
>> + device-wakeup-gpios = <&gpio2 RK_PD3 GPIO_ACTIVE_HIGH>;
>> + host-wakeup-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_HIGH>;
>> + shutdown-gpios = <&gpio0 RK_PB1 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
>> + vbat-supply = <&vcc3v3_sys>;
>> + vddio-supply = <&vcc_1v8>;
>> + };
>> };
>>
>> &uart2 {
>> --
>> 2.17.1
>>
>>
>> _______________________________________________
>> Linux-rockchip mailing list
>> Linux-rockchip@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>
Powered by blists - more mailing lists