[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 14:10:12 +0200
From: Gal Pressman <galpress@...zon.com>
To: Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>
CC: Max Hirsch <max.hirsch@...il.com>,
Doug Ledford <dledford@...hat.com>,
Parav Pandit <parav@...lanox.com>,
Steve Wise <swise@...ngridcomputing.com>,
Bart Van Assche <bvanassche@....org>,
Danit Goldberg <danitg@...lanox.com>,
Matthew Wilcox <willy@...radead.org>,
Dag Moxnes <dag.moxnes@...cle.com>,
Myungho Jung <mhjungk@...il.com>, <linux-rdma@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/cma: Fix checkpatch error
On 12/12/2019 10:49, Leon Romanovsky wrote:
> On Wed, Dec 11, 2019 at 12:26:54PM -0400, Jason Gunthorpe wrote:
>> On Wed, Dec 11, 2019 at 11:16:26AM +0000, Max Hirsch wrote:
>>> When running checkpatch on cma.c the following error was found:
>>
>> I think checkpatch will complain about your patch, did you run it?
>
> Jason, Doug
>
> I would like to ask to refrain from accepting checkpatch.pl patches
> which are not part of other large submission. Such standalone cleanups
> do more harm than actual benefit from them for old and more or less
> stable code (e.g. RDMA-CM).
Sounds like a great approach to prevent new developers from contributing code.
You have to start somewhere and checkpatch patches are a good entry point for
such developers, discouraging them will only hurt us in the long term.
Linus had an interesting post on the subject:
https://lkml.org/lkml/2004/12/20/255
Powered by blists - more mailing lists