linux-kernel - Re: [PATCH AUTOSEL 5.4 148/350] media: ad5820: Define entity function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 14:48:20 +0100
From:   Pavel Machek <pavel@....cz>
To:     Greg KH <greg@...ah.com>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        Ricardo Ribalda Delgado <ribalda@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 148/350] media: ad5820: Define entity function

> On Thu, Dec 12, 2019 at 01:19:38PM +0100, Pavel Machek wrote:
> > On Tue 2019-12-10 16:04:13, Sasha Levin wrote:
> > > From: Ricardo Ribalda Delgado <ribalda@...nel.org>
> > > 
> > > [ Upstream commit 801ef7c4919efba6b96b5aed1e72844ca69e26d3 ]
> > > 
> > > Without this patch, media_device_register_entity throws a warning:
> > > 
> > > dev_warn(mdev->dev,
> > > 	 "Entity type for entity %s was not initialized!\n",
> > > 	 entity->name);
> > 
> > This fixes warning, not a serious bug. Thus it is against stable
> > rules.
> 
> That's a good enough fix for a real issue.  We take patches in stable
> for this all the time.

I know you do this all the time...

But that's not what the documentation says you should be doing!

 - It must fix a problem that causes a build error (but not for things
    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
       security issue, or some "oh, that's not good" issue.  In short,
       something
          critical.

I'd prefer you to act as the documentation says you would, but even
just fixing the documentation would be improvement over current
situation.

Thanks,
								Pavel