linux-kernel - Re: [PATCH 0/2] watchdog: mtx-1: Relax build dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87f90857-633f-2437-4a26-a3b3dd7ea7c7@roeck-us.net>
Date:   Wed, 11 Dec 2019 17:39:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Denis Efremov <efremov@...ux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-watchdog@...r.kernel.org
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-mips@...ux-mips.org, Paul Burton <paulburton@...nel.org>
Subject: Re: [PATCH 0/2] watchdog: mtx-1: Relax build dependencies

On 12/11/19 3:46 PM, Denis Efremov wrote:
> Hi,
> 
> Thanks for the fix.
> I tested the compilation with these patches.
> You can add my:
> Tested-by: Denis Efremov <efremov@...ux.com>
> 
> Look like this error could be fixed the same way:
> In file included from drivers/watchdog/ar7_wdt.c:29:
> ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’:
> ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? [-Werror=implicit-function-declaration]
> 

This is yet another old-style watchdog driver which should be left alone
unless it has a bug that needs to be fixed. Really, if anyone out there
is still using this driver, converting it to use the watchdog core
would make much more sense.

Guenter