[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 16:51:25 +0100
From: Marc Gonzalez <marc.w.gonzalez@...e.fr>
To: Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Robin Murphy <robin.murphy@....com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Stephen Boyd <sboyd@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
LKML <linux-kernel@...r.kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Guenter Roeck <linux@...ck-us.net>,
linux-clk <linux-clk@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1] clk: Convert managed get functions to devm_add_action
API
On 12/12/2019 15:46, Russell King - ARM Linux admin wrote:
> However, please don't call this __clk_put().
> git grep __clk_put will tell you why. Thanks.
$ git grep __clk_put
drivers/clk/clk-devres.c:static void __clk_put(struct device *dev, void *data)
drivers/clk/clk-devres.c: if (!devm_add(dev, __clk_put, &clk, sizeof(clk)))
drivers/clk/clk.c:void __clk_put(struct clk *clk)
drivers/clk/clk.h:void __clk_put(struct clk *clk);
drivers/clk/clk.h:static inline void __clk_put(struct clk *clk) { }
drivers/clk/clkdev.c: __clk_put(clk);
I see. I will s/__clk_put/my_clk_put/ in my proposal.
Out of curiosity...
$ git grep __clk_put v2.6.29-rc1
v2.6.29-rc1:arch/arm/common/clkdev.c: __clk_put(clk);
v2.6.29-rc1:arch/arm/mach-ep93xx/include/mach/clkdev.h:#define __clk_put(clk) do { } while (0)
v2.6.29-rc1:arch/arm/mach-integrator/include/mach/clkdev.h:static inline void __clk_put(struct clk *clk)
v2.6.29-rc1:arch/arm/mach-pxa/include/mach/clkdev.h:#define __clk_put(clk) do { } while (0)
v2.6.29-rc1:arch/arm/mach-realview/include/mach/clkdev.h:#define __clk_put(clk) do { } while (0)
v2.6.29-rc1:arch/arm/mach-versatile/include/mach/clkdev.h:#define __clk_put(clk) do { } while (0)
Genesis seems to be 0318e693d3a56
The clkdev API expected platforms to export a __clk_put method?
Regards.
Powered by blists - more mailing lists