linux-kernel - Re: [PATCH] drivers: gpio: remove unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 17:10:55 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] drivers: gpio: remove unneeded MODULE_VERSION() usage

czw., 12 gru 2019 o 14:33 Enrico Weigelt, metux IT consult
<info@...ux.net> napisał(a):
>
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/gpio/gpio-sama5d2-piobu.c | 1 -
>  drivers/gpio/gpio-tb10x.c         | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c
> index b04c561f3280..4d47b2c41186 100644
> --- a/drivers/gpio/gpio-sama5d2-piobu.c
> +++ b/drivers/gpio/gpio-sama5d2-piobu.c
> @@ -244,7 +244,6 @@ static struct platform_driver sama5d2_piobu_driver = {
>
>  module_platform_driver(sama5d2_piobu_driver);
>
> -MODULE_VERSION("1.0");
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("SAMA5D2 PIOBU controller driver");
>  MODULE_AUTHOR("Andrei Stefanescu <andrei.stefanescu@...rochip.com>");
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index 5e375186f90e..866201cf5f65 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -243,4 +243,3 @@ static struct platform_driver tb10x_gpio_driver = {
>  module_platform_driver(tb10x_gpio_driver);
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("tb10x gpio.");
> -MODULE_VERSION("0.0.1");
> --
> 2.11.0
>

Patch applied.

Bart