linux-kernel - Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen

Open Source and information security mailing list archives

Date:   Thu, 12 Dec 2019 17:23:02 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Fabio Estevam <festevam@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6qdl: Enable egalax touch screen

On 19-12-12 17:07, Marco Felsch wrote:
> Hi Sjoerd,
> 
> On 19-12-12 17:02, Sjoerd Simons wrote:
> > Sabrelite boards can have an lvds screen attached with a built-in i2c touch
> > screen. Enable this in the dtsi.
> 
> Can this be any screen available on the market?

At least you should adapt the title to: "ARM: dts: imx6qdl-sabrelite: ..."

Regards,
  Marco


> 
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk>
> > ---
> > 
> >  arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > index 8468216dae9b..382b127b2251 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
> > @@ -416,6 +416,14 @@ &i2c3 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_i2c3>;
> >  	status = "okay";
> > +
> > +	touchscreen@4 {
> > +		compatible = "eeti,egalax_ts";
> > +		reg = <0x04>;
> > +		interrupt-parent = <&gpio1>;
> > +		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > +		wakeup-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> 
> The wakeup-gpio and the irq-line are sharing the same gpio line?
> 
> Regards,
>   Marco 
> 
> > +	};
> >  };
> >  
> >  &iomuxc {
> > -- 
> > 2.24.0
> > 
> > 
> > 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives