linux-kernel - Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 08:57:19 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>, linux-integrity@...r.kernel.org
Cc:     eric.snowberg@...cle.com, dhowells@...hat.com,
        mathew.j.martineau@...ux.intel.com, matthewgarrett@...gle.com,
        sashal@...nel.org, jamorris@...ux.microsoft.com,
        linux-kernel@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key"
 measurements

On 12/12/19 12:19 AM, Mimi Zohar wrote:

>>> +	ima_process_keys = true;
>> +
>> +	INIT_LIST_HEAD(&temp_ima_keys);
>> +
>> +	mutex_lock(&ima_keys_mutex);
>> +
>> +	list_for_each_entry_safe(entry, tmp, &ima_keys, list)
>> +		list_move_tail(&entry->list, &temp_ima_keys);
>> +
>> +	mutex_unlock(&ima_keys_mutex);
> 
> 
> The v1 comment, which explained the need for using a temporary
> keyring, is an example of an informative comment.  If you don't
> object, instead of re-posting this patch, I can insert it.
> 
> Mimi

Sure Mimi. Thanks for including the comment in the patch.

thanks,
  -lakshmi