[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 12:03:38 -0500
From: Barret Rhoden <brho@...gle.com>
To: Liran Alon <liran.alon@...cle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,
Dan Williams <dan.j.williams@...el.com>,
David Hildenbrand <david@...hat.com>,
Dave Jiang <dave.jiang@...el.com>,
Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
linux-nvdimm@...ts.01.org, x86@...nel.org, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, jason.zeng@...el.com
Subject: Re: [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files
On 12/12/19 7:33 AM, Liran Alon wrote:
>> + /*
>> + * Our caller grabbed the KVM mmu_lock with a successful
>> + * mmu_notifier_retry, so we're safe to walk the page table.
>> + */
>> + switch (dev_pagemap_mapping_shift(hva, current->mm)) {
> Doesn’t dev_pagemap_mapping_shift() get “struct page” as first parameter?
> Was this changed by a commit I missed?
I changed this in Patch 1. The place I call it in KVM has the address
and mm available, which is the only think dev_pagemap_mapping_shift()
really needs. (The first thing it did was convert page to address).
I'll add some more text to patch 1's commit message about that.
Thanks,
Barret
Powered by blists - more mailing lists