linux-kernel - Re: [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o8wd5bz1.wl-kuninori.morimoto.gx@renesas.com>
Date:   13 Dec 2019 09:02:43 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x


Hi Geert

Thank you for your review

> > __ashiftrt_r4_2x is used from kernel module.
> > We need DECLARE_EXPORT(), otherwise we will get compile error.
> >
> > ERROR: "__ashiftrt_r4_25" [drivers/iio/pressure/bmp280.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/dac/ad5764.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/mma7660.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/iio/accel/dmard06.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/bma220_spi.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/crypto/hisilicon/sec/hisi_sec.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/rtc/rtc-x1205.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf85063.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf2123.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/input/tablet/gtco.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/input/mouse/psmouse.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [drivers/input/mouse/psmouse.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [fs/udf/udf.ko] undefined!
(snip)
> Wouldn't it make sense to just add all of them (__ashiftrt_r4_[0-32])?

Oops, there are more missing __ashiftrt_r4_xx
Thank you for pointing it.
will post v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto