linux-kernel - Re: [PATCH resend] drm/exynos: gsc: add missed component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d8db84b-db75-10e4-81b5-c0c02cb8ce81@samsung.com>
Date:   Fri, 13 Dec 2019 13:05:37 +0900
From:   Inki Dae <inki.dae@...sung.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Joonyoung Shim <jy0922.shim@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] drm/exynos: gsc: add missed component_del

You don't need to resend this. Already merged to exynos-drm-fixes three weeks ago.

Thanks,
Inki Dae

19. 12. 6. 오전 1:05에 Chuhong Yuan 이(가) 쓴 글:
> The driver forgets to call component_del in remove to match component_add
> in probe.
> Add the missed call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> index 7ae087b0504d..88b6fcaa20be 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
> @@ -1313,6 +1313,7 @@ static int gsc_remove(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  
> +	component_del(dev, &gsc_component_ops);
>  	pm_runtime_dont_use_autosuspend(dev);
>  	pm_runtime_disable(dev);
>  
>