linux-kernel - Re: [PATCH] bus: ti-sysc: Fix missing reset delay handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ffb7088-8a10-c75a-1ad5-27701fad18e0@ti.com>
Date:   Fri, 13 Dec 2019 11:41:15 +0530
From:   Keerthy <j-keerthy@...com>
To:     Tony Lindgren <tony@...mide.com>, <linux-omap@...r.kernel.org>
CC:     "Andrew F . Davis" <afd@...com>, Dave Gerlach <d-gerlach@...com>,
        Faiz Abbas <faiz_abbas@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nishanth Menon <nm@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Roger Quadros <rogerq@...com>, Suman Anna <s-anna@...com>,
        Tero Kristo <t-kristo@...com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] bus: ti-sysc: Fix missing reset delay handling



On 12/12/19 12:29 am, Tony Lindgren wrote:
> We have dts property for "ti,sysc-delay-us", and we're using it, but the
> wait after OCP softreset only happens if devices are probed in legacy mode.
> 
> Let's add a delay after writing the OCP softreset when specified.


Hi Tony,

Boot tested on DRA72 & DRA76.

Tested for RTC+DDR mode and DS0 mode on AM437x.
Tested for DS0 on am335x-evm & am335x-beagle-bone-black.

FWIW

Tested-by: Keerthy <j-keerthy@...com>

- Keerthy


> 
> Fixes: e0db94fe87da ("bus: ti-sysc: Make OCP reset work for sysstatus and sysconfig reset bits")
> Cc: Keerthy <j-keerthy@...com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>
> ---
>  drivers/bus/ti-sysc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -1590,6 +1590,10 @@ static int sysc_reset(struct sysc *ddata)
>  	sysc_val |= sysc_mask;
>  	sysc_write(ddata, sysc_offset, sysc_val);
>  
> +	if (ddata->cfg.srst_udelay)
> +		usleep_range(ddata->cfg.srst_udelay,
> +			     ddata->cfg.srst_udelay * 2);
> +
>  	if (ddata->clk_enable_quirk)
>  		ddata->clk_enable_quirk(ddata);
>  
> 

Download attachment "pEpkey.asc" of type "application/pgp-keys" (8925 bytes)