linux-kernel - Re: [PATCH v3] mfd: syscon: Add arguments support for syscon reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191213082336.GD3468@dell>
Date:   Fri, 13 Dec 2019 08:23:36 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Orson Zhai <orson.zhai@...eadtrum.com>
Cc:     Rob Herring <robh@...nel.org>, Orson Zhai <orson.zhai@...soc.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        baolin.wang@...soc.com, kevin.tang@...soc.com,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        liangcai.fan@...soc.com, orsonzhai@...il.com
Subject: Re: [PATCH v3] mfd: syscon: Add arguments support for syscon
 reference

On Fri, 13 Dec 2019, Orson Zhai wrote:

> Hi Lee and Rob,
> 
> On Wed, Dec 11, 2019 at 02:55:39PM +0100, Arnd Bergmann wrote:
> > On Wed, Dec 11, 2019 at 5:09 AM Orson Zhai <orson.zhai@...soc.com> wrote:
> > >
> > > There are a lot of similar global registers being used across multiple SoCs
> > > from Unisoc. But most of these registers are assigned with different offset
> > > for different SoCs. It is hard to handle all of them in an all-in-one
> > > kernel image.
> > >
> > > Add a helper function to get regmap with arguments where we could put some
> > > extra information such as the offset value.
> > >
> > > Signed-off-by: Orson Zhai <orson.zhai@...soc.com>
> > > Tested-by: Baolin Wang <baolin.wang@...soc.com>
> >
> > Reviewed-by: Arnd Bergmann <arnd@...db.de>
> 
> Does this patch look good to be applied?
> 
> Or if any comments please feel free to send to me.

If it looks good to Arnd, it looks good to me.

I have quite a number of reviews to get through first though, please
bear with me and resist the urge to nag.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog