linux-kernel - Re: [PATCH v3] bluetooth: hci_bcm: enable IRQ capability from node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191213091809.GW10631@localhost>
Date:   Fri, 13 Dec 2019 10:18:09 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Guillaume La Roque <glaroque@...libre.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        BlueZ <linux-bluetooth@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, khilman@...libre.com,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3] bluetooth: hci_bcm: enable IRQ capability from node

On Thu, Dec 12, 2019 at 09:46:32PM +0100, Marcel Holtmann wrote:
> Hi Nicolas,
> 
> >> Actually IRQ can be found from GPIO but all platforms don't support
> >> gpiod_to_irq, it's the case on amlogic chip.
> >> so to have possibility to use interrupt mode we need to add interrupts
> >> field in node and support it in driver.
> >> 
> >> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> >> ---
> >> drivers/bluetooth/hci_bcm.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> > 
> > This triggers the following panic on Raspberry Pi 4:
> > 
> > [    6.634507] Unable to handle kernel NULL pointer dereference at virtual
> > address 0000000000000018

> >> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> >> index f8f5c593a05c..9f52d57c56de 100644
> >> --- a/drivers/bluetooth/hci_bcm.c
> >> +++ b/drivers/bluetooth/hci_bcm.c
> >> @@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device
> >> *serdev)
> >> {
> >> 	struct bcm_device *bcmdev;
> >> 	const struct bcm_device_data *data;
> >> +	struct platform_device *pdev;
> >> 	int err;
> >> 
> >> 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);
> >> @@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device
> >> *serdev)
> >> #endif
> >> 	bcmdev->serdev_hu.serdev = serdev;
> >> 	serdev_device_set_drvdata(serdev, bcmdev);
> >> +	pdev = to_platform_device(bcmdev->dev);
> > 
> > Ultimately bcmdev->dev here comes from a serdev device not a platform device,
> > right?
> 
> I was afraid of this, but then nobody spoke up. Can we fix this or
> should I just revert the patch?

Just revert it, the patch is plain broken and makes no sense.

As Nicolas pointed out, bcmdev->dev is a member of struct serdev_device
so cannot be cast to a platform device.

Johan