linux-kernel - Re: [PATCH] dt-bindings: pwm: fix nodename pattern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b0167ca-6797-b89a-dd61-fa6db30022f7@st.com>
Date:   Fri, 13 Dec 2019 11:09:51 +0000
From:   Benjamin GAIGNARD <benjamin.gaignard@...com>
To:     Rob Herring <robh+dt@...nel.org>,
        Alexandre TORGUE <alexandre.torgue@...com>
CC:     Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "Mark Rutland" <mark.rutland@....com>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: pwm: fix nodename pattern


On 12/12/19 8:07 PM, Rob Herring wrote:
> On Thu, Dec 12, 2019 at 2:16 AM Benjamin GAIGNARD
> <benjamin.gaignard@...com> wrote:
>>
>> On 12/11/19 8:52 PM, Rob Herring wrote:
>>> On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
>>> <benjamin.gaignard@...com> wrote:
>>>> Typical pwm nodes should be named pwm@....
>>>> The pattern shouldn't match nodes named pwm-xxx to avoid
>>>> conflicts with pinmux or pwm-fan nodes.
>>> It only matches pwm-$(a-hex-number), not any string, so that shouldn't
>>> be a problem. This is needed for things like GPIO based devices (not
>>> just PWMs) which don't have any address.
>>>
>>> Pinmux nodes are going to need to adopt some sort of standard pattern
>>> we can match on.
>> I have push a patch to stop using '@' and '_' in pinmux groups names:
>> https://lore.kernel.org/patchwork/patch/1162591/
>> It remove the warnings when compiling the devicetre with W=12 but pwm.yaml
>> complain because pwm pinmux is named pwm-1.
>>
>> How can I solve these issues at the same time ?
> Name the nodes *-pins or *-pins-[0-9]. You're probably going to need
> some pattern anyways when you do a pinmux schema.
+ Alex because that impact pin node pattern in st,stm32-pinctrl.yaml

Benjamin

> Rob