linux-kernel - Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191213113241.GA4644@sirena.org.uk>
Date:   Fri, 13 Dec 2019 11:32:41 +0000
From:   Mark Brown <broonie@...nel.org>
To:     jeff_chang(張世佳) <jeff_chang@...htek.com>
Cc:     Jeff Chang <richtek.jeff.chang@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

On Fri, Dec 13, 2019 at 07:36:15AM +0000, jeff_chang(張世佳) wrote:
> Dear Mark:
> 
> 
> 
>         Thanks for your replying. I consider that there was only one item I should modify. So I kept resending.
> 
> 
> 
>         Please refer my red comment after your comment.

I can't tell what's in red or not, kernel development gets done with
plain text e-mail.  Please fix your mail configuration, it is extremely
difficult to read your messages for this and other reasons.

> The writes to reserved registers should be fine but things like this which looks like it's configuring the input path should just be left at the chip default, we don't want to be configuring for particular boards since the same driver will be used for every board with the chip.
> 
> 
> 
>         The chip default cannot be modified anymore. How can I do if I really need write these setting in our drivers?

Settings should be done through some combination of userspace
configuration at runtime and device tree or ACPI properties.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)