linux-kernel - Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84f3ec5e-eda7-c955-2705-482263eb1ee6@gmail.com>
Date:   Fri, 13 Dec 2019 12:46:21 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Pkshih <pkshih@...ltek.com>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic
 functions

On 2019-12-12 02:47, Pkshih wrote:
> On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote:
>> This series converts the drivers rtl8192{ce,cu,de} to use the generic
>> functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
>>
>> Michael Straube (6):
>>    rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
>>    rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
>>    rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
>>    rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
>>    rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
>>    rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
>>
>>   .../wireless/realtek/rtlwifi/rtl8192ce/trx.c  | 48 ++----------------
>>   .../wireless/realtek/rtlwifi/rtl8192cu/mac.c  | 49 ++-----------------
>>   .../wireless/realtek/rtlwifi/rtl8192de/trx.c  | 47 ++----------------
>>   3 files changed, 14 insertions(+), 130 deletions(-)
>>
> 
> For all patches:
> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
> 

Thanks.

> Curiously. How can you find these function are identical?
> 
While sending cleanup patches for some staging wifi drivers I noticed
that these functions are used in many of the realtek drivers and all
looked very similar. Then used grep and diff to verify.

Michael