linux-kernel - Re: [PATCH bpf] bpf: clear skb->tstamp in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <523d7946-bb5f-39a3-8969-addb564fd73c@gmail.com>
Date:   Fri, 13 Dec 2019 09:49:57 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>, ast@...nel.org,
        daniel@...earbox.net, "David S. Miller" <davem@...emloft.net>,
        Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>,
        Richard Cochran <rcochran@...utronix.de>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kernel-team@...udflare.com
Subject: Re: [PATCH bpf] bpf: clear skb->tstamp in bpf_redirect when necessary



On 12/13/19 7:46 AM, Lorenz Bauer wrote:
> Redirecting a packet from ingress to egress by using bpf_redirect
> breaks if the egress interface has an fq qdisc installed. This is the same
> problem as fixed in 8203e2d8 ("net: clear skb->tstamp in forwarding paths").
> 
> Clear skb->tstamp when redirecting into the egress path.
> 
> Fixes: 80b14de ("net: Add a new socket option for a future transmit time.")

Please use 12 digits sha1


> Fixes: fb420d5 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>

Thanks for fixing this !