linux-kernel - Re: [PATCH 4.19 099/243] usb: dwc3: debugfs: Properly print/set link state for HS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3c4d47c-ae00-1b5a-1894-d48da26ed5fd@synopsys.com>
Date:   Fri, 13 Dec 2019 19:23:12 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 099/243] usb: dwc3: debugfs: Properly print/set link
 state for HS

Hi,

Pavel Machek wrote:
> On Wed 2019-12-11 16:04:21, Greg Kroah-Hartman wrote:
>> From: Thinh Nguyen <thinh.nguyen@...opsys.com>
>>
>> [ Upstream commit 0d36dede457873404becd7c9cb9d0f2bcfd0dcd9 ]
>>
>> Highspeed device and below has different state names than superspeed and
>> higher. Add proper checks and printouts of link states for highspeed and
>> below.
> This is debugfs, so I don't believe it was suitable for stable in the
> first place, but....
>
>
>> +	case DWC3_LINK_STATE_RESUME:
>> +		return "Resume";
>> +	default:
>> +		return "UNKNOWN link state\n";
>> +	}
> You may want to delete \n here, it will be duplicated if this ever
> triggers.

We already fixed it upstream:
038761ce68c2 ("usb: dwc3: debug: Remove newline printout")

> Best regards,
> 								Pavel

BR
Thinh