linux-kernel - [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191213203512.8250-1-makiftasova@gmail.com>
Date:   Fri, 13 Dec 2019 23:35:10 +0300
From:   Mehmet Akif Tasova <makiftasova@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     makiftasova@...il.com, Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Shahar S Matityahu <shahar.s.matityahu@...el.com>,
        Tova Mussai <tova.mussai@...el.com>,
        Ayala Beker <ayala.beker@...el.com>,
        Sara Sharon <sara.sharon@...el.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] Revert "iwlwifi: mvm: fix scan config command size"

Since Linux 5.4.1 released, iwlwifi could not initialize Intel(R) Dual Band
Wireless AC 9462 firmware, failing with following error in dmesg:

iwlwifi 0000:00:14.3: FW error in SYNC CMD SCAN_CFG_CMD

whole dmesg output of error can be found at:
https://gist.github.com/makiftasova/354e46439338f4ab3fba0b77ad5c19ec

also bug report from ArchLinux bug tracker (contains more info):
https://bugs.archlinux.org/task/64703

Reverting commit 06eb547c4ae4 ("iwlwifi: mvm: fix scan config command
size") seems to fix this issue  until proper solution is found.

This reverts commit 06eb547c4ae4382e70d556ba213d13c95ca1801b.

Signed-off-by: Mehmet Akif Tasova <makiftasova@...il.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
index a046ac9fa852..a5af8f4128b1 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
@@ -1213,7 +1213,7 @@ static int iwl_mvm_legacy_config_scan(struct iwl_mvm *mvm)
 		cmd_size = sizeof(struct iwl_scan_config_v2);
 	else
 		cmd_size = sizeof(struct iwl_scan_config_v1);
-	cmd_size += num_channels;
+	cmd_size += mvm->fw->ucode_capa.n_scan_channels;
 
 	cfg = kzalloc(cmd_size, GFP_KERNEL);
 	if (!cfg)
-- 
2.24.1