linux-kernel - Re: [PATCH 04/58] tty/serial: Migrate aspeed_vuart to use has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Dec 2019 12:02:05 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Dmitry Safonov" <dima@...sta.com>, linux-kernel@...r.kernel.org
Cc:     "Dmitry Safonov" <0x7f454c46@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Jiri Slaby" <jslaby@...e.com>,
        "Vasiliy Khoruzhick" <vasilykh@...sta.com>,
        linux-serial@...r.kernel.org, "Joel Stanley" <joel@....id.au>,
        linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH 04/58] tty/serial: Migrate aspeed_vuart to use has_sysrq



On Fri, 13 Dec 2019, at 10:36, Dmitry Safonov wrote:
> The SUPPORT_SYSRQ ifdeffery is not nice as:
> - May create misunderstanding about sizeof(struct uart_port) between
>   different objects
> - Prevents moving functions from serial_core.h
> - Reduces readability (well, it's ifdeffery - it's hard to follow)
> 
> In order to remove SUPPORT_SYSRQ, has_sysrq variable has been added.
> Initialise it in driver's probe and remove ifdeffery.
> 
> Cc: Andrew Jeffery <andrew@...id.au>
> Cc: Joel Stanley <joel@....id.au>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-aspeed@...ts.ozlabs.org
> Signed-off-by: Dmitry Safonov <dima@...sta.com>

Acked-by: Andrew Jeffery <andrew@...id.au>