linux-kernel - Re: [PATCH v4 06/16] dyndbg: fix a BUG_ON in ddebug_describe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfuBxwggurCvoUq23ZVcDJ1P6TaPVvCvAWkmxw9p9__sx8OTQ@mail.gmail.com>
Date:   Thu, 12 Dec 2019 18:35:01 -0700
From:   jim.cromie@...il.com
To:     Jason Baron <jbaron@...mai.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, akpm@...uxfoundation.org,
        Greg KH <gregkh@...uxfoundation.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH v4 06/16] dyndbg: fix a BUG_ON in ddebug_describe_flags

On Tue, Dec 10, 2019 at 12:58 PM Jason Baron <jbaron@...mai.com> wrote:
> >
> > +struct flagsbuf { char buf[12]; };   /* big enough to hold all the flags */
>
>
> ARRAY_SIZE(opt_array) + 1
>
> max number of flags + string termination.
>


Ok  12 is generous.
v2 had xyz flags, for a total of 9+1 flag chars.
figured a multiple of 4 was sensible, almost went to 16
then didnt think about it anymore.