linux-kernel - Re: [PATCH v2] mm/gup: Fix memory leak in __gup_benchmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b167e207-f919-be9a-08cb-1d1a56e25e37@web.de>
Date:   Sat, 14 Dec 2019 19:10:55 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        Ira Weiny <ira.weiny@...el.com>,
        John Hubbard <jhubbard@...dia.com>, linux-mm@...ck.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Keith Busch <keith.busch@...el.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Navid Emamdoost <emamd001@....edu>
Subject: Re: [PATCH v2] mm/gup: Fix memory leak in __gup_benchmark_ioctl

…
> +++ b/mm/gup_benchmark.c
…
> @@ -85,8 +85,9 @@  static int __gup_benchmark_ioctl(unsigned int cmd,
>  	end_time = ktime_get();
>  	gup->put_delta_usec = ktime_us_delta(end_time, start_time);
>
> +done:
>  	kvfree(pages);
> -	return 0;
> +	return ret;
>  }
>
>  static long gup_benchmark_ioctl(struct file *filep, unsigned int cmd,

Can the addition of a label like “free_pages” be more appropriate here?

Regards,
Markus