linux-kernel - [PATCH] Re: memory leak in reiserfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbad2a8f-5a58-ecb5-eec7-1d6ef90abaed@infradead.org>
Date:   Sat, 14 Dec 2019 15:12:57 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     syzbot <syzbot+1c6756baf4b16b94d2a6@...kaller.appspotmail.com>,
        deepa.kernel@...il.com, jack@...e.cz, jeffm@...e.com,
        jlayton@...nel.org, linux-kernel@...r.kernel.org,
        reiserfs-devel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        viro@...iv.linux.org.uk
Subject: [PATCH] Re: memory leak in reiserfs_fill_super

From: Randy Dunlap <rdunlap@...radead.org>

fill_super() conditionally allocates a jdev string if "jdev=x"
is specified.  put_super() should free that memory.

Reported-by: syzbot+1c6756baf4b16b94d2a6@...kaller.appspotmail.com
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
---
 fs/reiserfs/super.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20191213.orig/fs/reiserfs/super.c
+++ linux-next-20191213/fs/reiserfs/super.c
@@ -629,6 +629,7 @@ static void reiserfs_put_super(struct su
 	reiserfs_write_unlock(s);
 	mutex_destroy(&REISERFS_SB(s)->lock);
 	destroy_workqueue(REISERFS_SB(s)->commit_wq);
+	kfree(REISERFS_SB(s)->s_jdev);
 	kfree(s->s_fs_info);
 	s->s_fs_info = NULL;
 }