linux-kernel - [tip: x86/cleanups] x86/process: Remove set but not used variables prev and next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <157630928132.30329.4530483129490664469.tip-bot2@tip-bot2>
Date:   Sat, 14 Dec 2019 07:41:21 -0000
From:   "tip-bot2 for yu kuai" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     yu kuai <yukuai3@...wei.com>, Borislav Petkov <bp@...e.de>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "x86-ml" <x86@...nel.org>, yi.zhang@...wei.com,
        zhengbin13@...wei.com, LKML <linux-kernel@...r.kernel.org>
Subject: [tip: x86/cleanups] x86/process: Remove set but not used variables
 prev and next

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     27353d5785bca61bb49cfd7c78e14f1d21e66ec5
Gitweb:        https://git.kernel.org/tip/27353d5785bca61bb49cfd7c78e14f1d21e66ec5
Author:        yu kuai <yukuai3@...wei.com>
AuthorDate:    Fri, 13 Dec 2019 20:12:53 +08:00
Committer:     Borislav Petkov <bp@...e.de>
CommitterDate: Sat, 14 Dec 2019 08:26:00 +01:00

x86/process: Remove set but not used variables prev and next

Remove two unused variables:

  arch/x86/kernel/process.c: In function ‘__switch_to_xtra’:
  arch/x86/kernel/process.c:618:31: warning: variable ‘next’ set but not used [-Wunused-but-set-variable]
    618 |  struct thread_struct *prev, *next;
        |                               ^~~~
  arch/x86/kernel/process.c:618:24: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
    618 |  struct thread_struct *prev, *next;
        |

They are never used and so can be removed.

Signed-off-by: yu kuai <yukuai3@...wei.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: x86-ml <x86@...nel.org>
Cc: yi.zhang@...wei.com
Cc: zhengbin13@...wei.com
Link: https://lkml.kernel.org/r/20191213121253.10072-1-yukuai3@huawei.com
---
 arch/x86/kernel/process.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 61e93a3..839b524 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -615,12 +615,8 @@ void speculation_ctrl_update_current(void)
 
 void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p)
 {
-	struct thread_struct *prev, *next;
 	unsigned long tifp, tifn;
 
-	prev = &prev_p->thread;
-	next = &next_p->thread;
-
 	tifn = READ_ONCE(task_thread_info(next_p)->flags);
 	tifp = READ_ONCE(task_thread_info(prev_p)->flags);